SasView / sasmodels

Package for calculation of small angle scattering models using OpenCL.
BSD 3-Clause "New" or "Revised" License
15 stars 27 forks source link

be_polyelectrolyte model needs proper validation check (Trac #1186) #394

Open butlerpd opened 5 years ago

butlerpd commented 5 years ago

An error in the be_polyelectrolyte model was identified prior to release 4.2.0 and corrected. The error has been carried since 1998 and there was no quick and easy external validation of that change, partly because the implementation doesn't exactly follow the paper. It would be good if somebody could go through the paper and ensure that the code follows so that the disclaimer note in the docs can be removed.

Migrated from http://trac.sasview.org/ticket/1186

{
    "status": "new",
    "changetime": "2018-09-28T17:32:06",
    "_ts": "2018-09-28 17:32:06.332106+00:00",
    "description": "An error in the be_polyelectrolyte model was identified prior to release 4.2.0 and corrected.  The error has been carried since 1998 and there was no quick and easy external validation of that change, partly because the implementation doesn't exactly follow the paper.  It would be good if somebody could go through the paper and ensure that the code follows so that the disclaimer note in the docs can be removed.",
    "reporter": "butler",
    "cc": "",
    "resolution": "",
    "workpackage": "McSAS Integration Project",
    "time": "2018-09-28T17:32:06",
    "component": "SasView",
    "summary": "be_polyelectrolyte model needs proper validation check",
    "priority": "critical",
    "keywords": "",
    "milestone": "SasView 4.3.0",
    "owner": "",
    "type": "defect"
}
butlerpd commented 4 years ago

This is clearly a sasmodels issue not a sasview on so moving it over now.