search

SasView / sasmodels

Package for calculation of small angle scattering models using OpenCL.
BSD 3-Clause "New" or "Revised" License
15 stars 27 forks source link

Be consistent with categorisation of pearl models #426

Open smk78 opened 4 years ago

smk78 commented 4 years ago

The pearl_necklace model is categorised as a cylinder function, but the linear_pearls model is categorised as a sphere function. This seems arbitrary. We should be consistent.

butlerpd commented 3 years ago

categories are defined as tags really so that any model can belong to several categories. This was envisaged for grouping in different ways for projects for example but could be applied here in that both models could be categorized as both sphere and cyclinder?

smk78 commented 2 years ago

I understand what you are saying @butler, but I still think it is inconsistent that a linear string of spheres is categorised as a 'sphere' model but a non-linear string of spheres is a 'cylinder'! If a user were searching for one or other models they could easily miss it as things stand.

butlerpd commented 2 years ago

Agreed things should be consistant. That is clear. I meant to be proposing a solution to the fact that clearly different people think they should be categorized differently (I assume that is how the discrepancy came about?). That said I am not sure if a model can be defined straight up as belonging to two "built-in" categories or not, in which case, either we should change that or my proposal is not a solution 😃