search

SasView / sasmodels

Package for calculation of small angle scattering models using OpenCL.
BSD 3-Clause "New" or "Revised" License
15 stars 27 forks source link

FIX: turned magic constants to named magic constants. Refs #468 #470

Closed pkienzle closed 2 years ago

pkienzle commented 3 years ago

Mixture models such as "cylinder+sphere" broke when an additional orientation parameter was added to the applied field for magnetic systems. This was reported in #468 as inadequate testing of models. The PR fixes the problem but does not close the testing ticket.

wpotrzebowski commented 3 years ago

@smk78 will try to take a look

butlerpd commented 2 years ago

@smk78 still needs to look at.

butlerpd commented 2 years ago

sasmodels ready for testing on Win

wpotrzebowski commented 2 years ago

@butlerpd I took a look at the code and it looks fine to me. I would vote for merging it.