search

SasView / sasmodels

Package for calculation of small angle scattering models using OpenCL.
BSD 3-Clause "New" or "Revised" License
15 stars 27 forks source link

allow composite mixtures with multiplicity #468 #472

Closed pkienzle closed 2 years ago

pkienzle commented 3 years ago

Fixes "core_multi_shell*hardsphere + cylinder" and "core_multi_shell@hardsphere + cylinder" noted in #468.

Note that this applies after #470

butlerpd commented 2 years ago

@butlerpd and @wpotrzebowski to look at

wpotrzebowski commented 2 years ago

ready for testing on OSX

wpotrzebowski commented 2 years ago

sasmodels ready for testing on OSX

wpotrzebowski commented 2 years ago

Code looks generally good. I haven't tested functionality yet.

wpotrzebowski commented 2 years ago

Not directly related to this but help button from Add/Multipy window redirects to wrong place. Screen Shot 2021-10-27 at 19 57 25 Will try to fix it.

wpotrzebowski commented 2 years ago

ready for testing on OSX

wpotrzebowski commented 2 years ago

sasmodels ready for testing on OSX

wpotrzebowski commented 2 years ago

sasmodels ready for testing on OSX

wpotrzebowski commented 2 years ago

I've tested functionality. It works as expected (as far as I can tell). There are some tests failing due python 3.6 not being avaialable on github actions. It needs to be addressed separetly.