search

SasView / sasmodels

Package for calculation of small angle scattering models using OpenCL.
BSD 3-Clause "New" or "Revised" License
16 stars 28 forks source link

Use up_theta instead of up_angle as model parameter names for consistency #473

Closed pkienzle closed 3 years ago

pkienzle commented 3 years ago

Orientation angles are θ, φ, ψ most everywhere but magnetic orientation uses up_angle and up_phi for historical reasons. Rename up_angle to up_theta and make sure that older models get converted.

Verify that θ, φ use the same orientation system as the particle axis, both for applied field and for orientation of the magnetism within the particle.

Also, make sure that models saved without up_phi are loaded correctly in versions that support arbitrary applied field.

dehoni commented 3 years ago

The ticket looks like a doublicate of ticket 471 .