search

SasView / sasmodels

Package for calculation of small angle scattering models using OpenCL.
BSD 3-Clause "New" or "Revised" License
16 stars 28 forks source link

Update test.yml #481

Closed wpotrzebowski closed 3 years ago

wpotrzebowski commented 3 years ago

It seems that python 3.6 test is no longer supported for osx. The question is if we should extend for new ver. of python e.g. 3.9

butlerpd commented 3 years ago

Hummm... on the one hand sounds dangerous just before a release.. on the other hand from 3.6 to 3.9 should not be breaking and actually I suspect that many of us are actually running 3.9 locally (build machines) anyway?

I guess if it is the only way to get OSX to build on actions we should go for it and hope for the best? At least I'll vote for that. What could possibly go wrong 😃

pkienzle commented 3 years ago

Don't know why the doc build is failing and breaking our CI. My temptation is to strip any WARNING.*py:class from the log before checking.

pkienzle commented 3 years ago

In direct_model.py type Kernel and type KernelModel are used in practically the same environment (both imported from kernel.py solely for type hinting; both have docstrings in kernel.py), yet one causes a sphinx nitpick warning and the other does not. I would rather turn off the broken sphinx nitpick than remove type hints from the code.

Trying with type annotations rather than type in docstrings to see if sphinx can handle it better. This will break python 2.7 compatibility, which we shouldn't care about anymore since 2.7 is no longer supported. A much better solution than removing the type hints, assuming it works.

The tests have now run, and it seems like the type annotation solution will work. Maybe because the symbol is actually used in the file now, whereas it was unused before (with type hints in the comments the interpreter didn't know the symbols were used).

I'm trying something similar for the Calculator symbol problem in compare.py, but I'll reverse it if it fails the tests.

Are we ready for a complete break from 2.7, preferably to 3.8 so we can use Protocol without installing typing_extensions?

butlerpd commented 3 years ago

Sad as it makes me, I think trying to maintain python 2.7 compatibility is just getting silly. We can say the last sasmodels version is the last that will work under 2.7? it is always available if somebody wants to use it I guess?

wpotrzebowski commented 3 years ago

sasmodels ready for testing on OSX