search

SasView / sasmodels

Package for calculation of small angle scattering models using OpenCL.
BSD 3-Clause "New" or "Revised" License
15 stars 27 forks source link

Fix confusing slit nomenclature #528

Closed pbeaucage closed 1 year ago

pbeaucage commented 1 year ago

In sasview/sasview#1753, we discuss that sasview adopted non-standard (or maybe better pre-standard, or neutron-specific) nomenclature for which axis in slit smearing is the short one and which is the long one.

canSAS defines the slit width as the narrow axis, and the slit length as the long axis. We currently call width the narrow axis but call the long axis height, which is correct in the horizontal-scattering USANS geometry but incorrect in a vertical scattering geometry. Length is direction-agnostic and thus preferred, I think. It would be good to revise our resolution calculator to use this nomenclature as well to avoid confusion.

butlerpd commented 1 year ago

closing ticket after merging changes