search

SasView / sasmodels

Package for calculation of small angle scattering models using OpenCL.
BSD 3-Clause "New" or "Revised" License
15 stars 27 forks source link

Change slit nomenclature from qx-qy to width-length #530

Closed pbeaucage closed 1 year ago

pbeaucage commented 1 year ago

As discussed at length in sasview/sasview#1753 and described here in #528 this changes the nomenclature throughout from the confusing qx_width and qy_width to the canSAS standard q_length and q_width, where length is the long axis of the slit and width the short axis.

This depends on and is linked to issue sasview/sasview#1753 and PR sasview/sasview#2283

pbeaucage commented 1 year ago

edit: nevermind, sorted now.

I would particularly appreciate eyes on 9e9403c which changed a definition in a test; this definition seems obviously flipped but...

pbeaucage commented 1 year ago

Should now be ready for re-review.