SasView / sasmodels

Package for calculation of small angle scattering models using OpenCL.
BSD 3-Clause "New" or "Revised" License
16 stars 28 forks source link

Changes in #563 break SasView main #573

Open lucas-wilkins opened 1 year ago

lucas-wilkins commented 1 year ago

The changes in #563 have caused some issues with DirectModel as it used in SasView (and probably peoples scripts).

The text of #563 says its only an error that will occur outside of SasView and just requires different parameter names, but SasView is affected. Whilst changing the names does remove the error, it results in calculations that are incorrect (in parallelepiped at least, a -> length_a etc).

lucas-wilkins commented 1 year ago

The bug is back.