search

SasView / sasmodels

Package for calculation of small angle scattering models using OpenCL.
BSD 3-Clause "New" or "Revised" License
15 stars 27 forks source link

Disable name check #574

Closed lucas-wilkins closed 1 year ago

lucas-wilkins commented 1 year ago

This fixed #573 and https://github.com/SasView/sasview/issues/2577

It's probably not the optimal fix, but it works, and can be used until something better comes along.

lucas-wilkins commented 1 year ago

Note: there is a branch in SasView that contains the appropriate changes in parameters

butlerpd commented 1 year ago

Ouch .. if it breaks things "pretty hard" should we instead be reverting that merge? Adding @pkienzle to the reviewer list since it is apparently his PR that broke things?

lucas-wilkins commented 1 year ago

It's not so bad, but can add Paul of you like

On Sun, 6 Aug 2023, 20:45 Paul Butler, @.***> wrote:

Ouch .. if it breaks things "pretty hard" should we instead be reverting that merge? Adding @pkienzle https://github.com/pkienzle to the reviewer list since it is apparently his PR that broke things?

— Reply to this email directly, view it on GitHub https://github.com/SasView/sasmodels/pull/574#issuecomment-1666953054, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACKU4SVG27LRTHZKQVNGFATXT7X65ANCNFSM6AAAAAA3EUOTNE . You are receiving this because you authored the thread.Message ID: @.***>

lucas-wilkins commented 1 year ago

Yeah, although this check didn't exist before, so I think it will do for now until we figure out how it should be.

On Mon, Aug 7, 2023 at 8:29 AM Wojciech Potrzebowski < @.***> wrote:

@.**** approved this pull request.

It seems quite dangerous but it seems to work (at least I haven't discovered any serious issues while performing functionality tests).

Orientantion viewer seems to work again in (at least in my local branch).

— Reply to this email directly, view it on GitHub https://github.com/SasView/sasmodels/pull/574#pullrequestreview-1564716237, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACKU4SVRRAEMF36PKRK7BHTXUCKNHANCNFSM6AAAAAA3EUOTNE . You are receiving this because you authored the thread.Message ID: @.***>

--

Dr Lucas Wilkins +44 (0) 7505 915 726

Personal Website: http://www.lucaswilkins.com/ Alternate e-mail: @.***

butlerpd commented 1 year ago

so should we make sure then to reopen #573 once this is merged and add comment that this tourniquet stops the bleeding but it still needs proper fixing?