search

SasView / sasmodels

Package for calculation of small angle scattering models using OpenCL.
BSD 3-Clause "New" or "Revised" License
16 stars 28 forks source link

Use numpy>=2 #613

Open krzywon opened 3 weeks ago

krzywon commented 3 weeks ago

This allows sasmodels to use numpy>=2. This also fixes two sphinx warnings that were happening during the build.

Fixes #604 Fixes #598 Refs #609

bobleesj commented 1 day ago

@krzywon Thanks for this PR, just wondering, will this PR be reviewed or merged?

krzywon commented 1 day ago

@bobleesj, a review is required before a merge can be made into sasmodels, but that review can come from anyone who wasn't the original PR creator. Would you feel comfortable, and have the time to review it?

bobleesj commented 23 hours ago

@krzywon yes happy to review. Will do later in the afternoon.

bobleesj commented 21 hours ago

@krzywon Great! 3.12 is working here. For our group's package, we also plan to support Python 3.13. If it's not too much trouble, could you please check if 3.13 works as well?

sbillinge commented 21 hours ago

btw, I am not sure who has write access and can provide a review. Are either of the Pauls (@pkienzle @butlerpd ) or Matthieu (@mdoucet ) still actively maintaining this? conda-forge is already shipping python 3.13 as latest so we are migrating all our diffpy codes over. I just am wondering who is leading the maintenance on here these days?

krzywon commented 18 hours ago

@bobleesj, I've added the py3.13 test, as requested. Let's see what happens!

@sbillinge, I spoke to @pkienzle, and he says he will take a look when he has a chance.

krzywon commented 18 hours ago

I rolled back from py3.13. The build is failing to find a compatible pyopencl wheel. I could probably build from source, but that is beyond the scope of this PR.

bobleesj commented 17 hours ago

I rolled back from py3.13. The build is failing to find a compatible pyopencl wheel. I could probably build from source, but that is beyond the scope of this PR.

Yes. Thanks a ton!

andyfaff commented 17 hours ago

For reference, https://numpy.org/doc/stable/numpy_2_0_migration_guide.html