search

SasView / sasview

Code for the SasView application.
BSD 3-Clause "New" or "Revised" License
51 stars 41 forks source link

make sure 1D data masks apply to fits (Trac #1055) #1113

Open pkienzle opened 5 years ago

pkienzle commented 5 years ago

Following up from ticket #1104, [https://github.com/SasView/sasview/pull/135 PR http://trac.sasview.org/ticket/135], make sure that masking applies to resolution and fits in 1D datasets.

Migrated from http://trac.sasview.org/ticket/1055

{
    "status": "new",
    "changetime": "2018-02-13T02:48:24",
    "_ts": "2018-02-13 02:48:24.630207+00:00",
    "description": "Following up from ticket #1037, [https://github.com/SasView/sasview/pull/135 PR #135], make sure that masking applies to resolution and fits in 1D datasets.\n",
    "reporter": "pkienzle",
    "cc": "",
    "resolution": "",
    "workpackage": "SasView Bug Fixing",
    "time": "2018-01-03T17:42:06",
    "component": "SasView",
    "summary": "make sure 1D data masks apply to fits",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView 4.3.0",
    "owner": "",
    "type": "defect"
}
butlerpd commented 5 years ago

Trac update at 2018/02/13 02:48:24: butler changed milestone from "SasView 4.2.0" to "SasView 4.3.0"

butlerpd commented 4 years ago

This indeed needs to be looked into. I am guessing that 1D masks are part of the SasView 1Ddata object structure? though not even sure of that since most early 1D formats do not include masks for 1D data. But masking in general was not something that was thought of much in the original SasView implementation. It was added for 2D fitting but there is nothing added for 1D (and arguably even less necessary for 1D reduced data than 2D?). The NXcanSAS format does allow for masks so should be able to respect that. Guessing however we can move this to 5.1

krzywon commented 4 years ago

The 1D data structure has no concept of masks. The mask object for the 2D data was built into the parent plottable_2D class but was never implemented in plottable_1D. Once the mask is added to the plottable class, passing it to the GUI and perspectives might need to be added.