SasView / sasview

Code for the SasView application.
BSD 3-Clause "New" or "Revised" License
51 stars 41 forks source link

PDF Report should contain SasView Version Number (Trac #1179) #1215

Closed smk78 closed 5 years ago

smk78 commented 5 years ago

I'm putting this in for 4.2, but it equally applies to 5.0.

A colleague here in ISIS was struggling to reload a .svs project created over 2 years ago in a previous position. At issue was which version of !SasView the project had been created in.

By trial-and-good-fortune we discovered that the project had been created in 4.0.1 and then discovered it involved a plugin model that was naturally missing. Recreating the plugin then allowed the project to load ok, but VERY slowly.

@krzywon will be delighted to hear that with the plugin 4.2.0Beta loads the project like greased lightning!

However, a moral from this story is that given model names, algorithms, and save states have, and may again in the future, change, it would be disciplined and professional of us to include the !SasView version number in the PDF Report.

Migrated from http://trac.sasview.org/ticket/1179

{
    "status": "closed",
    "changetime": "2018-10-01T09:14:25",
    "_ts": "2018-10-01 09:14:25.572417+00:00",
    "description": "I'm putting this in for 4.2, but it equally applies to 5.0.\n\nA colleague here in ISIS was struggling to reload a .svs project created over 2 years ago in a previous position. At issue was which version of !SasView the project had been created in.\n\nBy trial-and-good-fortune we discovered that the project had been created in 4.0.1 and then discovered it involved a plugin model that was naturally missing. Recreating the plugin then allowed the project to load ok, but VERY slowly.\n\n@krzywon will be delighted to hear that with the plugin 4.2.0Beta loads the project like greased lightning!\n\nHowever, a moral from this story is that given model names, algorithms, and save states have, and may again in the future, change, it would be disciplined and professional of us to include the !SasView version number in the PDF Report.\n",
    "reporter": "smk78",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "Reporting Enhancements",
    "time": "2018-09-20T13:54:09",
    "component": "SasView",
    "summary": "PDF Report should contain SasView Version Number",
    "priority": "blocker",
    "keywords": "",
    "milestone": "SasView 4.2.0",
    "owner": "",
    "type": "enhancement"
}
butlerpd commented 5 years ago

Trac update at 2018/09/27 14:44:01: butler commented:

Do not believe this is really a blocker for 4.2 and don't see that anybody has the bandwidth to add in reasonable time. Should discuss -- either it is a blocker or we need to move to 4.3 where it can remain at "critical" level. Leaving this as "Critical" for now even though we should have nothing but blockers left.

sasview-bot commented 5 years ago

Trac update at 2018/09/28 19:42:41: krzywon commented:

In changeset e9920cd1fef162ad399cc9f42a588bb14006c327:

#!CommitTicketReference repository="sasview" revision="e9920cd1fef162ad399cc9f42a588bb14006c327"
Add SasView version to report files. #1215
butlerpd commented 5 years ago

Trac update at 2018/09/29 00:45:03:

OK .. not really something that should stop a long overdue version 4.2, but since it was easy enough and is now a PR making this a blocker till the PR is merged and the ticket closed

butlerpd commented 5 years ago

Trac update at 2018/09/30 22:04:59:

Closed with merging of !SasView PR 185. In merging forgot to add the appropriate magical closes #1215

smk78 commented 5 years ago

Trac update at 2018/10/01 09:14:25: smk78 commented:

Downloaded Win64 Build 432 and checked. Version number is there in the report. Thanks Jeff!