Include fabio for loading 2D X-ray detector data

smk78 commented 4 years ago

Enhancement suggestion.

Olivier Tache (of pySAXS) suggests that SasView should support reading of 2D X-ray detector images by linking the fabio library (https://pypi.org/project/fabio/).

For:

would give SasView greater traction with the SAXS community
SasView wouldn't have to maintain multiple readers itself

Against:

SasView has always marketed itself as an application that operates on reduced data (though it does have an image viewer...)
Support for the only raw image data format (the NIST pixel format) was dropped by agreement
It's (yet) another dependency

The argument would thus seem to rest on the purpose of supporting raw detector image data. Easy access to flexible slicer functionality (currently served by FIT2D (ageing), DAWN (overkill), or Mantid (poor)) would be one key reason.

RichardHeenan commented 4 years ago

Are the potential users wanting to fit wide Q range models or simply use sasview tools to extract slices & wedges etc ? ( but then fit to the extracts ?)
If they are fitting models to 2d data, is the raw data sufficiently good these days to allow this ? (Perhaps only in a limited area of detector ?) Will they then also be asking for fitting of multiple (Bragg) peaks in the 2d data ? i.e. could we have some anticipated work flows ( As mentioned above, I am concerned that poor results may appear in print due to fitting "raw" data.)

butlerpd commented 9 months ago

orking on cleanup in preparation for Contributor Camp XII:

Humm... based on this conversation @krzywon, @smk78, @RichardHeenan and @timsnow, I'm wondering if this should not be a discussion item rather than a ticket at this point? adding a reader to the list of reader that is actually for raw data seems problematic unless it is to replace the file converter module we currently have? Or does this package also read in fully reduced SAXS data formats? Or as suggested @snow is it typical to run analysis on raw SAXS data?

Or is the interest not so much for the readers but for the slicers to replace our own code?

SasView / sasview

Include fabio for loading 2D X-ray detector data #1572