search

SasView / sasview

Code for the SasView application.
BSD 3-Clause "New" or "Revised" License
51 stars 41 forks source link

Image viewer (converter) does not allow for, or indicate, the choice of Q units. #1811

Open butlerpd opened 3 years ago

butlerpd commented 3 years ago

When loading an image file and clicking convert, the user must enter the Qmax and Qmin in (I believe) units of A^-1. It would be nice to offer the option of units much as is being done for the load data currently in progress under review #1802 and discussed in issue #1465. However to a minimum the labeling of the text entry box should be changed from the current x values from pixel # to: X_min (or X_max, Y_min,Y_max) to something like: x values from pixel # to:Q_min (1/A) etc.

I assume the z value is expected to be in arbitrary units but a statement of such would be useful.

If the minimum of fixing labels is done a new ticket should be generated before closing this one for the option of choosing the units (assuming the data object will carry native units) though downgrading to minor might be appropriate?

lucas-wilkins commented 2 years ago

@krzywon What is the state of this with regards to the new units?

krzywon commented 2 years ago

@lucas-wilkins Still needs to remain open and I didn't realize this was required until now.