SasView / sasview

Code for the SasView application.
BSD 3-Clause "New" or "Revised" License
51 stars 41 forks source link

Show the hard block volume fraction in corfunc #2110

Open lucas-wilkins opened 2 years ago

lucas-wilkins commented 2 years ago

Migrated from #1502

"compute & display the "Hard Block Volume Fraction"

What is the hard block volume fraction @smk78

lucas-wilkins commented 2 years ago

What is the hard block volume fraction @smk78

nudge @smk78

lucas-wilkins commented 2 years ago

@smk78 ??

smk78 commented 2 years ago

Right... this turned out to be a head slapper! I remembered reading something somewhere but it's taken me time to find it again (for reference, footnote 80 on p145 of Stribeck's book!). The hard block volume fraction is nothing more than an alternative name for the local crystallinity! But, it is a better, more generic, name! The reason being that if you use a word like 'crystallinity' what interpretation do you take away if you know your sample is not actually crystalline? Correlation function analysis is not limited to crystalline samples, it's just that the proponents that developed the field mostly worked with crystalline polymers. So, to summarise, this is just a change of wording on the Corfunc GUI.

smk78 commented 2 years ago

However, I think there is another issue about verifying exactly what values are being displayed for these parameters? It might be an idea to reconsider the parameter names as that is done... Probably best if we do that jointly @lucas-wilkins .

lucas-wilkins commented 2 years ago

It might be an idea to reconsider the parameter names as that is done... Probably best if we do that jointly @lucas-wilkins .

OK, I'm back on the 15th. I also notice that the output fields lack tool tips, this might be a place to mention that there are different names.