SasView / sasview

Code for the SasView application.
BSD 3-Clause "New" or "Revised" License
51 stars 41 forks source link

Resolution calculator fails to compute image #2705

Open wpotrzebowski opened 10 months ago

wpotrzebowski commented 10 months ago

Describe the bug Q resolution calculator from Tools doesn't compute expected resolution image and returns error: ERROR: list index out of range. The same behavior is observed reagardless of whether you choose monochromatic or TOF source.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Q Resolution Estimator' in 'Tools'
  2. Click on 'Compute'
  3. See error

Expected behavior https://www.sasview.org/docs/user/qtgui/Calculators/resolution_calculator_help.html

Screenshots Screenshot 2024-01-14 at 07 43 37

SasView version (please complete the following information):

Operating system (please complete the following information):

Additional context While working on fix for this issue, it may be worth checking https://github.com/SasView/sasview/issues/1270

rozyczko commented 10 months ago

1st test, release_6.0.0 branch, developer build, Win10

The exception is coming from unnecessary check in sascalc\calculator\resolution_calculator.py line 1007. removing this check makes the calculation succeed without the errors shown.

Will test with the installer build

rozyczko commented 10 months ago

Win10 Release build works the same as dev version. I will remove the check and let's see how it works on macos

rozyczko commented 10 months ago

@wpotrzebowski please test the installer from 2705-resolution-calculator-fails-to-compute-image and see if it still fails to display the image

butlerpd commented 4 months ago

Humm..., It seems this has been fixed and then forgotten?!! Can we just make a pull request from branch 2705-resolution-calculator-fails-to-compute-image for release 6.0? of course it may need to be cherry picked onto release_6.0.0 at this point?