search

SasView / sasview

Code for the SasView application.
BSD 3-Clause "New" or "Revised" License
51 stars 41 forks source link

Write perspective code for pore size distribution calculation #2765

Open ajj opened 9 months ago

ajj commented 9 months ago

Write perspective code that can take Data1d objects and maxent parameters and call the GSAS II methods for doing the maxent calculation of size distribution. Discussion of how this should work is needed - what should be returned for example? @AnitaZhang0526

lucas-wilkins commented 9 months ago

Just copy & paste P(r)?

AnitaZhang0526 commented 9 months ago

We should clarify that we are trying to use the maximum entropy method implemented in Irena instead of using the least square fit of the Fourier transform of P(r). I think we did talk about where to put our new code, and the idea of integrating it into P(r) did come up at one point. But because we are also trying to make our method work with more than one form factor in the future, we think it may be a good idea to do a separate perspective. @ajj and @murphyryanp can probably add to this.

lucas-wilkins commented 9 months ago

We should clarify that we are trying to use the maximum entropy method implemented in Irena instead of using the least square fit of the Fourier transform of P(r).

I wasn't saying use the same calculation, it's just that P(r) is very similar and it would save a lot of work to start from a copy of that. Lots of things to hook up that would just be a matter of swapping a few things over.

But because we are also trying to make our method work with more than one form factor in the future,

Might be nice to have P(r) calculated though maxent too, as its essentially just a different form factor (hollow spheres instead of solid spheres).