Added automated signing of the Windows installer - Githubissues

SasView / sasview

Code for the SasView application.

BSD 3-Clause "New" or "Revised" License

47 stars 41 forks source link

Added automated signing of the Windows installer #2891

Closed rozyczko closed 1 month ago

rozyczko commented 1 month ago

Description

Automated binary signing of the installer with ESS Digicert credentials

How Has This Been Tested?

Local checks

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

[X] There is nothing that needs documenting
[ ] Documentation changes are in this PR
[ ] There is an issue open for the documentation (link?)

Installers

[ ] There is a chance this will affect the installers, if so
- [X] Windows installer (GH artifact) has been tested (installed and worked)
- [ ] MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

[x] The introduced changes comply with SasView license (BSD 3-Clause)

rozyczko commented 1 month ago

We probably don't need to sign every single branch installer and only limit the process to the release installers.