Plotting Preferences also impact Report

SasView / sasview

Code for the SasView application.

BSD 3-Clause "New" or "Revised" License

47 stars 41 forks source link

Plotting Preferences also impact Report #2911

Open smk78 opened 6 days ago

smk78 commented 6 days ago

Describe the bug If you turn off plotting of residuals/polydispersity in Preferences they don't get plotted even though the data are computed. This was the intended behaviour.

However, it appears that if you don't create a plot it will not get added to the Report.

I would argue this is most undesirable and could lead to misunderstandings and poor science.

I think it would be preferable for residuals/polydispersity to always be included in the Report when they are computed.

lucas-wilkins commented 3 days ago

Is this a 6.0.0 issue? Given that we're in the process of redoing all this anyway, why hold the release up for it?

smk78 commented 2 days ago

It's a 6.0.0 issue in the sense that we have changed behaviour, in this case for the worse (IMHO).