search

Sasai-Kudasai-BM / Water-Physics-Overhaul

48 stars 17 forks source link

Glass pane bug #51

Open caramellizedd opened 2 years ago

caramellizedd commented 2 years ago

So i found a bug that makes water pass-through glass-pane i dont know if this do the same on other partial-typed blocks if you need video for proof i would gladly record it and sent one

bearsjunior commented 2 years ago

This is cause Glass panes can be waterlogged so it will work with other blocks

Felicis commented 1 year ago

Specifically the reason is that

  1. glass panes are waterlogged, so they can contain water and let water pass through (like fences and iron bars)
  2. glass panes do not have a full side, like for example stairs. WPO checks internally whether a block's side is completely blocked, and does not move water through that side.

It would be pretty easy to add a check to prevent water flow through glass panes, but without completely overhauling the rendering and filling only part of the block, it would look really odd with water either not touching the glass or protruding through it.