search

SasanLabs / VulnerableApp-facade

VulnerableApp-facade is probably most modern lightweight distributed farm of Vulnerable Applications built for handling wide range of vulnerabilities across tech stacks.
Apache License 2.0
45 stars 48 forks source link

feat: Add unit tests for AboutUs component #65

Closed Dripcoding closed 2 years ago

Dripcoding commented 2 years ago

Add unit tests for AboutUs page

preetkaran20 commented 2 years ago

Hi @Dripcoding ,

After the last commit which you made, one of the job is failing with error:

#10 37.35 > ejs@2.7.4 postinstall /usr/src/app/node_modules/ejs
#10 37.35 > node ./postinstall.js
#10 37.35 
#10 37.40 Thank you for installing EJS: built with the Jake JavaScript build tool (https://jakejs.com/)
#10 37.40 
#10 37.68 
#10 37.68 > es5-ext@0.10.59 postinstall /usr/src/app/node_modules/es5-ext
#10 37.68 > node -e "try{require('./_postinstall')}catch(e){}"
#10 37.68 
#10 39.29 npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.13 (node_modules/webpack-dev-server/node_modules/fsevents):
#10 39.29 npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.13: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
#10 39.30 npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.13 (node_modules/watchpack-chokidar2/node_modules/fsevents):
#10 39.30 npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.13: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
#10 39.31 npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.3.2 (node_modules/fsevents):
#10 39.31 npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.3.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
#10 39.31 
#10 39.32 added 1805 packages from 765 contributors and audited 1813 packages in 30.964s
#10 40.29 
#10 40.29 159 packages are looking for funding
#10 40.29   run `npm fund` for details
#10 40.29 
#10 40.29 found 27 vulnerabilities (2 low, 9 moderate, 15 high, 1 critical)
#10 40.29   run `npm audit fix` to fix them, or `npm audit` for details
#10 DONE 42.7s

#11 [builder 6/7] COPY ./facade-app .
#11 DONE 0.0s

#12 [builder 7/7] RUN npm run build
#12 0.475 
#12 0.475 > facade-app@0.1.0 build /usr/src/app
#12 0.475 > react-scripts build
#12 0.475 
#12 2.021 Creating an optimized production build...
#12 26.12 Failed to compile.
#12 26.12 
#12 26.12 /usr/src/app/src/App.tsx
#12 26.12 TypeScript error in /usr/src/app/src/App.tsx(215,79):
#12 26.12 No overload matches this call.
#12 26.12   Overload 1 of 2, '(props: Props | Readonly<Props>): Footer', gave the following error.
#12 26.12     Type '{ children: string; globalState: GlobalState; setGlobalState: (globalState: GlobalState) => void; copyRightYear: number; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Footer> & Readonly<Props> & Readonly<{ children?: ReactNode; }>'.
#12 26.12       Property 'copyRightYear' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Footer> & Readonly<Props> & Readonly<{ children?: ReactNode; }>'.
#12 26.12   Overload 2 of 2, '(props: Props, context: any): Footer', gave the following error.
#12 26.12     Type '{ children: string; globalState: GlobalState; setGlobalState: (globalState: GlobalState) => void; copyRightYear: number; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Footer> & Readonly<Props> & Readonly<{ children?: ReactNode; }>'.
#12 26.12       Property 'copyRightYear' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Footer> & Readonly<Props> & Readonly<{ children?: ReactNode; }>'.  TS[276](https://github.com/SasanLabs/VulnerableApp-facade/runs/5639189602?check_suite_focus=true#step:3:276)9
#12 26.12 
#12 26.12     213 |           ></Content>
#12 26.12     214 |         </RSuiteContainer>
#12 26.12   > 215 |         <Footer globalState={this.state} setGlobalState={this.setGlobalState} copyRightYear={copyRightYear}>
#12 26.12         |                                                                               ^
#12 26.12     216 |           Footer
#12 26.12     217 |         </Footer>
#12 26.12     218 |       </RSuiteContainer>
#12 26.12 
#12 26.12 
#12 26.16 npm ERR! code ELIFECYCLE
#12 26.16 npm ERR! errno 1
#12 26.16 npm ERR! facade-app@0.1.0 build: `react-scripts build`
#12 26.16 npm ERR! Exit status 1
#12 26.16 npm ERR! 
#12 26.16 npm ERR! Failed at the facade-app@0.1.0 build script.
#12 26.16 npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
#12 26.17 
#12 26.17 npm ERR! A complete log of this run can be found in:
#12 26.17 npm ERR!     /root/.npm/_logs/2022-03-22T05_42_13_[276](https://github.com/SasanLabs/VulnerableApp-facade/runs/5639189602?check_suite_focus=true#step:3:276)Z-debug.log
#12 ERROR: executor failed running [/bin/sh -c npm run build]: exit code: 1
------
 > [builder 7/7] RUN npm run build:
#12 26.16 npm ERR! code ELIFECYCLE
#12 26.16 npm ERR! errno 1
#12 26.16 npm ERR! facade-app@0.1.0 build: `react-scripts build`
#12 26.16 npm ERR! Exit status 1
#12 26.16 npm ERR! 
#12 26.16 npm ERR! Failed at the facade-app@0.1.0 build script.
#12 26.16 npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
#12 26.17 
#12 26.17 npm ERR! A complete log of this run can be found in:
#12 26.17 npm ERR!     /root/.npm/_logs/2022-03-22T05_42_13_276Z-debug.log
------
error: failed to solve: executor failed running [/bin/sh -c npm run build]: exit code: 1
Error: buildx failed with: error: failed to solve: executor failed running [/bin/sh -c npm run build]: exit code: 1

can you please have a look and fix it.

thanks, Karan

Dripcoding commented 2 years ago

@preetkaran20 This PR contains the fix for the issue you mentioned. I've confirmed this by running npm run build locally. For the future, we might want to run the npm run build script upon opening PRs as well.

preetkaran20 commented 2 years ago

@preetkaran20 This PR contains the fix for the issue you mentioned. I've confirmed this by running npm run build locally. For the future, we might want to run the npm run build script upon opening PRs as well.

Right, we do that as well but now sure why it failed. Let me see that

preetkaran20 commented 2 years ago

added PR: https://github.com/SasanLabs/VulnerableApp-facade/pull/66 for handling npm run build in PR creation as well.

preetkaran20 commented 2 years ago

@Dripcoding Invited you to core-vulnerableapp-ui github team.

thanks, Karan

Dripcoding commented 2 years ago

@preetkaran20 thanks Karan! I'm happy to contribute to the project :) I've opened this issue for documentation https://github.com/SasanLabs/VulnerableApp-facade/issues/67