Closed TomerPacific closed 11 months ago
@TomerPacific I think you removed the logic related to using the flag shouldSendRequestsAfterFindingVulnerability. please add that. The place where you added the logic is correct.
thanks, Karan
@preetkaran20 - Yes, I removed the logic per your recommendations. I'll add the logic back.
@preetkaran20 - Please review again. Also, if you could add the hacktoberfest-accepted label.
I think UI can be changed a little bit like below:
i.e. changing label and checkbox order.
can we rename label of checkbox to something like Keep exploiting after discovery.
or Keep exploiting vulnerabilities after discovery
or Keep exploiting after discovering vulnerabilities
etc. thoughts?
`
@preetkaran20 - I'll change the UI according to your recommendation.
@TomerPacific changes looks good to me. Just one thing, please align the UI flag to left and make label first and then the checkbox as shown in the below image:
@preetkaran20 - Still working on the changes, am not finished. Will let you know when I am done.
@preetkaran20 - I think I managed to produce the UI changes you requested.
Let me know if anything else is necessary.
Fixes #19