search

SasanLabs / owasp-zap-jwt-addon

OWASP ZAP addon for finding vulnerabilities in JWT Implementations
https://www.zaproxy.org/
Apache License 2.0
30 stars 12 forks source link

ScanRule Naming Consistency #7

Closed kingthorin closed 4 years ago

kingthorin commented 4 years ago

Related to: https://github.com/zaproxy/zaproxy/issues/6049

https://github.com/SasanLabs/owasp-zap-jwt-addon/blob/master/src/main/java/org/zaproxy/zap/extension/jwt/JWTActiveScanner.java should be renamed JWTActiveScanRule or JwtActiveScanRule

Of course you don't have to conform to that since this is project is 3rd party, so close/address as you see fit. But it's a pretty simple change and helps bring consistency and clarity/specificity.

preetkaran20 commented 4 years ago

@kingthorin Sure will take care of this.

Keenal commented 4 years ago

I will like to work on this, please let me know if I can!

preetkaran20 commented 4 years ago

Hi @Keenal ,

Assigned it to you. Thanks, Karan

Keenal commented 4 years ago

Done! #13