search

Sascha-L / WPF-MediaKit

Microsoft Public License
367 stars 116 forks source link

framestep added, framerate added to mediadetector, playerstate added #69

Open skaterlui opened 6 years ago

skaterlui commented 6 years ago

Added framestep and ratioslider to sample application.

skaterlui commented 6 years ago

Finally. I got it. I deleted my repo and forked it once more. Then I commited all changes at once.

skaterlui commented 6 years ago

@xmedeko Good morning Ondrej, is this pr good for you? Or should I change anything? have a nice day Markus

skaterlui commented 6 years ago

@xmedeko how about my pr? It would be so nice if you could merge my changes.

xmedeko commented 6 years ago

@skaterlui The frame step code itself looks good to me.

I am just not sure about the player state. IMO the states in this library are not solved well, see also #57. I have no time to investigate the problem more in depth and I am just helping to maintain this lib. This project needs some chief maintainer who will make complex decisions, even break backward compatibility sometimes.

So, I can separate and merge just the frame step code, if you are happy with that.