Sascha-L / WPF-MediaKit

Microsoft Public License
363 stars 115 forks source link

stop close and xp issues with the player #78

Closed ahmed-abdelrazek closed 6 years ago

ahmed-abdelrazek commented 6 years ago
  1. the stop button on the test app work like the pause button it should return the playtime to 0 and preview image for the player

  2. the player doesn't work on windows XP with microsoft visual c++, directx and lav filter installed also no mention in the wiki about the need for microsoft visual c++ 2015

  3. the method to close the video doesn't dispose it from the player and it kept loaded without the ability to do anything to the file until i open another one

xmedeko commented 6 years ago

What renderer do you use? VMR9 should not need to install VS C++ redistributable. The EVR may need it, compile it with lower version by yourself if you need lower version of the redistributable.

About the Stop and Pause, you are right, they are same or similar. I do not know the details. Check DirectX IMediaControl .Stop() and IMediaControl .Pause().

ahmed-abdelrazek commented 6 years ago

for xp i used the default settings only the test app atleat on my test machines (xp - 7 - 8.1 - 10) needed the microsoft visual c++ 2015 or at least one dll file from it i can't recall it's name

the same settings on xp will get me an error when opening the app that some dll file from directx is missing and when i install it the app runs but it can't play anything and gives me an error for the player

xmedeko commented 6 years ago

Yes, this library works on most of machines, but sometimes one may found some problems. It's very hard to help you if you report "or at least one dll file from it i can't recall it's name". Also, this is a library, not player. You should have some C# programming knowledge to track down the problems.

Just try to switch to VMR9. Also check the error details in Debug.Trace output or configure logging (see Wiki) if you cannot use Debug.Trace.

ahmed-abdelrazek commented 6 years ago

i am a C# Developer any way what i am trying to say is on windows xp the test app with the source code doesn't even start without the directx and the visual c++ but after installing them the app runs but the player controller itself show an error when playing any file

i don't recall the file name because it was a month ago but i don't have time then to report the issue sorry i will test it again and i would be happy to give you the exact info about the problem

skaterlui commented 6 years ago
  1. Check #66
  2. I think it's about the target framework version. The test app and the library targets .NET 4.5 The last .NET framework version for xp was 4.0 https://docs.microsoft.com/en-gb/dotnet/framework/get-started/system-requirements
xmedeko commented 6 years ago

Well, if it's about .NET version I think the library may be compiled to .NET 4, but some minor changes will be necessary. Do you have some reason to use XP and not Windows 7?

ahmed-abdelrazek commented 6 years ago

nope, i rebuilt it targeting the dotnet 4.0 that why i could run the test app on XP but the player controller still give me an error when playing any video but the same dotnet 4.0 app runs ok on 7 8.1 and 10 with visual c++ 2015 installed without the need for the DirectX which was weird when the app itself ask for it on XP and wouldn't open the player controller still give me an error unable to play anything after i installed the latest DirectX on xp

no, there isn't i was just testing the library and was wondering is it a bug with the library or someting i did?

xmedeko commented 6 years ago

I repeat: check if the problem is in the EVR or VMR9 renderers, send the error.

ahmed-abdelrazek commented 6 years ago

https://imgur.com/a/HJerIjF

xmedeko commented 6 years ago

Well, MF.dll is a part of Media Foundation, I think it cannot be installed on WindowsXP. But better you check in by yourself. If not, then you have to use VMR9.

The error about the "Splitter graph" is caused by DirectX, do you have a proper codecs installed? You must choose some lower version of K-Lite codecs which supports XP.

ahmed-abdelrazek commented 6 years ago

i will try again thanks

ahmed-abdelrazek commented 6 years ago

DirectX and Visual c++ is already installed + the latest LAV filter that supports XP

https://imgur.com/a/7bLe8FU

Maybe because it's a VM?!

xmedeko commented 6 years ago

Yep, some VMs don't support DirectX, check dxdiag.exe -> Display -> Direct3D Acceleration.

ahmed-abdelrazek commented 6 years ago

yep, there is a problem with the VM i will try to test it on a real machine