Closed SaschaRadojkovic closed 1 year ago
vercel[bot]
commented
1 year ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated |
|---|---|---|---|---|
| capstone-project | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Jan 29, 2023 at 3:04PM (UTC) |
TariqAlQadi
commented
1 year ago Puhh .. that's a lot! It might take a while for me to take a look at it
SaschaRadojkovic
commented
1 year ago Puhh .. that's a lot! It might take a while for me to take a look at it
i know. if not, its not so schlimm ;) someone will do it one day ;)
TariqAlQadi
commented
1 year ago I can't review this for now, but maybe you explain some things beforehand (for example .. what quagga, etc does .. i had to google it)
SaschaRadojkovic
commented
1 year ago I can't review this for now, but maybe you explain some things beforehand (for example .. what quagga, etc does .. i had to google it)
quagga is the bacodescanner package . in the scanner or barcode scanner file there is a link to quagga source ..window dimensions scanner and barcodescanner component are part of that .. NoSSR is for disable serverside rendering because of problems with the scanner .. the vercel.json file is for some compatibility problems with vercel deployment because that was a pure javascript code before
doemser
commented
1 year ago We talked a lot about it and gave your project a refactor. Please pass the PR again into reviews.
SaschaRadojkovic
commented
1 year ago Nice work Sascha 💪
thanks
Here i implemented the barcode scanner this is a npm package i have found, installed and reworked to get rid of divs and inline styling.
Please be aware that the numbers that are scanned are not always correct. Scan it again until you get the correct number. later when fetching the api it will be an output e.g. "no product found scan again" that result accuracy can later be modified with the errorRate.maybe the user will get option to adjust his scanner related to his device/camera.