Persistant Data - Githubissues

SaschaRadojkovic / capstone-project

https://capstone-project-amber.vercel.app

1 stars 0 forks source link

Persistant Data #7

Open SaschaRadojkovic opened 1 year ago

SaschaRadojkovic commented 1 year ago

Value Proposition

As a User
I want my allergene and additive settings to be saved so that i can see them again after switching between the two categories

Description

Acceptance Criteria

[x] The user can switch between the categories without loosing the selected items

Tasks

[x] install jotai to your project.
[x] make the selected items pesistant with jotai using useAtom / atomWithStorage.

Complexity

... (T-Shirt Sizes XS )

AstridOttmann commented 1 year ago

Looks good! I would suggest a few changes:

in tasks you write 'use localStorage or mongoDB', but afterwards you only mention, how you handle the database - if you have already decided to implement the database here, leave the localStorage out
'rewrite the code to make it work' doesn't say anything - leave it out or be more concrete
complexity is missing (S -M -L ...)
do you need one or two models? - one for additives and one for allergens - or can both be handled with one model?

SaschaRadojkovic commented 1 year ago

Hey , astrid thanks for the review . The complexity is on L maybe you did not see it . The other points i will rewrite.

AGeck113 commented 1 year ago

Hi Sascha, looks a little bit early, to implement the mongoDB. Maybe you can solve it for now with a state? Besides that, creating two APIs with three methods for each, the two models, create the database and connect it seems to be a little to big for one us. Maybe you can think of it again.