add search function to AllergenCard component

SaschaRadojkovic / capstone-project

https://capstone-project-amber.vercel.app

1 stars 0 forks source link

add search function to AllergenCard component #8

Closed SaschaRadojkovic closed 1 year ago

SaschaRadojkovic commented 1 year ago

here i added a search bar and a full list of allergens as a json file. you can now search for allergens than you get a grey styled preview of all found and you can select one to the input field and then press ADD button.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
capstone-project	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Jan 23, 2023 at 9:30AM (UTC)

AstridOttmann commented 1 year ago

Good job! Two suggestions:

it would be nice, if the input field would be reseted after submitting. At the moment I have to delete it manually if I want to search a second time
in App, line 6 you write 'Allergens' one time with an 'e' before the 's' and one time without (also naming the component is not consistent) - this might cause problems later

d-opri commented 1 year ago

tiny thing: your file for your 'AllergenCard' in the components folder is written AllergeneCard. otherwise lgtm :)

SaschaRadojkovic commented 1 year ago

tiny thing: your file for your 'AllergenCard' in the components folder is written AllergeneCard. otherwise lgtm :)

you are right . i was a little bit confused about the correct spelling in the beginning