Support for VS 2017?

[SaschaWillems]

Works fine with VS2017. There is a separate branch if you want to compile yourself, but I also uploaded a VS2017 compatbile extension to the VS marketplace.

[krupitskas]

Not working for me. I have 2017 Enterprise.

[krupitskas]

Also in your Readme written that only 2015 supported

[SaschaWillems]

Not working for me. I have 2017 Enterprise.

I only tested with the community editions. Looks like the enterprise version has different installation target ID. Will have to check that.

[krupitskas]

Okay, also I using cmake (open folder in vs 2017), not solution. So that's can be problem too, I think, cause even NShader not highlighting anything.

[SaschaWillems]

Does the extension install then? If it's installed and you don't see the popup menu entries to compile the shaders they may use a differing extension scheme.

[krupitskas]

Yes, everything others works like a charm except this two. Can you try open your cmake in visual studio 2017 and try compile shader and I will try open your repository with .sln tonight and write here results

[SaschaWillems]

The menu entries only show up if you select a folder or multiple files in the solution explorer with a supported file extension (.vert, .frag, *.geom, etc.), so the shader has to be part of the solution file. That works fine over here, but if you create the projects from cmake the shaders won't be added as solution files.

[krupitskas]

Maybe rewrite logic to support any shaders, even not part of solution?

[krupitskas]

I mean that .sln support folder tree view as and filters. Is that working there?

[krupitskas]

1) Checked in .sln you extension, works like a charm. 2) Updated NShader, it works now in solution and in CMake folder (developer fixed some bugs 25 days ago, so seems like I met some of this bugs). So I can rename this ticked to - Support for VS 2017 - Open Folder with CMakeLists.txt functionality.

[SaschaWillems]

So if I understand this correctly you want the extension to work based on the file-system rather than solution items as the CMakeLists.txt (from my examples e.g.) doesn't add the shaders to the solution?

If so I'd say the correct way would be to change my CMakeLists.txt to also add the shaders to the solution files for the examples.

[dmiller423]

If so I'd say the correct way would be to change my CMakeLists.txt to also add the shaders to the solution files for the examples.

This isn't exactly how things work these days, cmake is built into the IDE's and doesn't just generate a sln/vcproj, the most common scheme doesn't even use msbuild anymore it uses ninja by default.

I think his means of communicating this aren't great, it would be nice for this to work based on an open file for syntax at least, though build is probably best handled in cmake.

I realize it's a 2yr old issue, but it's still open so I thought i'd add some input.

[Keith-Albright-Bose]

Just tried a compute shader in VS 2017 Enterprise (.comp extension) and no color highlighting, no menu. Extension is listed as installed.

Added to solution yet no change. This shader works in VS Code with the Shader languages support for VS Code and Shaderc GLSL Linter extensions. Was hoping to use this in VS 2017