search

SaschaWillems / Vulkan-glTF-PBR

Physical based rendering with Vulkan using glTF 2.0 models
MIT License
961 stars 130 forks source link

Build broken? #12

Closed yozhijk closed 5 years ago

yozhijk commented 5 years ago

I am getting a bunch of build errors in VS2017 related to stbi after tinygltf update: https://github.com/SaschaWillems/Vulkan-glTF-PBR/commit/db99bb6760507359b6a681c4b6e8a709c9787206

1>c:\dev\pbr\base\stb_image.h(764): error C2371: 'stbicontext': redefinition; different basic types 1>c:\dev\pbr\base\stb_image.h(764): note: see declaration of 'stbi__context' 1>c:\dev\pbr\base\stb_image.h(771): error C2084: function 'void stbistart_mem(stbicontext ,const stbi_uc ,int)' already has a body 1>c:\dev\pbr\base\stb_image.h(770): note: see previous definition of 'stbistart_mem' 1>c:\dev\pbr\base\stb_image.h(780): error C2084: function 'void stbistart_callbacks(stbi__context ,stbi_io_callbacks ,void *)' already has a body 1>c:\dev\pbr\base\stb_image.h(779): note: see previous definition of 'stbistart_callbacks'

SaschaWillems commented 5 years ago

Can you please check again with the latest commit? I did some clean up and removed an unused tinygltf include in the main unit that may have caused this problem.

This builds without problems for me on VS2017 and Android Studio.

yozhijk commented 5 years ago

Works now, thanks!