search

SaschaWillems / Vulkan-glTF-PBR

Physical based rendering with Vulkan using glTF 2.0 models
MIT License
961 stars 130 forks source link

Segfaults in some models within animations #14

Closed fl0at88 closed 5 years ago

fl0at88 commented 5 years ago

likes this https://sketchfab.com/models/844ba0cf144a413ea92c779f18912042

SaschaWillems commented 5 years ago

I'm already aware of this. That model's bone count is higher than the max. number of joints currently supported by this example.

I have merged a PR that checks this limit, so the model should not longer segfault but will also not display correct because some meshes have more joints than the code currently supports.

fl0at88 commented 5 years ago

The model display correct when i set the value to 128

SaschaWillems commented 5 years ago

I have increased the limit to 128 joints and also introduced a define in the loader and the vertex shader that you can increase if you need more.