Materials PBR loading in VulkanglTFModel.cpp

[alexkh]

What is going on in VulkanglTFModel.cpp?

            if (mat.additionalValues.find("emissiveFactor") != mat.additionalValues.end()) {
                material.emissiveFactor = glm::vec4(glm::make_vec3(mat.additionalValues["emissiveFactor"].ColorFactor().data()), 1.0);
                material.emissiveFactor = glm::vec4(0.0f);
            }

first, a vec4 is created, then a new vec4 filled with zeroes is created? Why?

Will the following do the trick?

        material.emissiveFactor = glm::vec4(mat.emissiveFactor[0],
            mat.emissiveFactor[1], mat.emissiveFactor[2], 1.0);

[SaschaWillems]

That's most probably unintentional. Will take a look at this.