search

SaschaWillems / Vulkan-glTF-PBR

Physical based rendering with Vulkan using glTF 2.0 models
MIT License
915 stars 124 forks source link

Problem with animations #69

Closed RajdeepKonwar closed 8 months ago

RajdeepKonwar commented 8 months ago

Hello Sascha,

Animations are not working correctly in the viewer. For instance, when I load the AnimatedMorphCube model from the official glTF sample models repo, nothing is animating! Same with the AnimatedMorphSphere model - I believe I remember them animating a few months back. AnimatedTriangle is still working - haven't checked rest of the models.

Another issue which I encountered is if I hardcode the AnimatedTriangle model to load by default instead of the DamagedHelmet - I get this error: image

image

I am a big fan of your work and would highly appreciate if you could take some time to fix this!

Thanks, Rajdeep

SaschaWillems commented 8 months ago

That's to be expected. Morph targets aren't implemented, and as such glTF files that use them may either fail to load or aren't displayed correct (see https://github.com/SaschaWillems/Vulkan-glTF-PBR#gltf-20-model-loading). As of now I don't have plans to add support for morph targets.

RajdeepKonwar commented 8 months ago

Ah, got it!

But what about the crash which I see when I load the AnimatedTriangle model as the default model to start with? I believe that model has just a simple rotating animation.

SaschaWillems commented 8 months ago

The animated triangle sample from the repo you linked works fine for me.

RajdeepKonwar commented 8 months ago

Bizarre - I am not able to reproduce it anymore either! Thanks anyway!