search

SaschaWillems / Vulkan-glTF-PBR

Physical based rendering with Vulkan using glTF 2.0 models
MIT License
979 stars 132 forks source link

Unfreed memory #9

Closed rextimmy closed 2 years ago

rextimmy commented 6 years ago

Hi there sascha,

Just noticed in VulkanglTFModel.hpp there a few vectors that hold pointers and they are not deleted anywhere. https://github.com/SaschaWillems/Vulkan-glTF-PBR/blob/master/base/VulkanglTFModel.hpp#L366 & https://github.com/SaschaWillems/Vulkan-glTF-PBR/blob/master/base/VulkanglTFModel.hpp#L537

syoyo commented 4 years ago

I think this issue will be solved once PR https://github.com/SaschaWillems/Vulkan-glTF-PBR/pull/36 has been merged.

IAmNotHanni commented 2 years ago

(Can this issue be closed now?)