Closed Ybalrid closed 9 months ago
Sadly can't accept this. The min. play store requirement for targetSdkVersion
is 33 as of August 2023. With this change I would no longer be able to release updates to the store. The only version I could lower is the minSdkVersion
.
I see. I'd be happy to see that minimum version lowered to 29 at least. I have edited my branch for that, but now I have another question:
How is VulkanDeviceInfoExtensions.cpp
being generated?
I have removed from this branch the typecast that I've added, but I would like to double-check why the QVariant constructor was not able to be called in the toolchain I was using
How is
VulkanDeviceInfoExtensions.cpp
being generated?
See https://github.com/SaschaWillems/VulkanCapsViewer/blob/master/docs/update_headers.md
How is
VulkanDeviceInfoExtensions.cpp
being generated?See https://github.com/SaschaWillems/VulkanCapsViewer/blob/master/docs/update_headers.md
Thanks, will take a look soon.
PHP is an interesting choice of scripting language 🙂
It was a perfect match from my POV. If you want to change something about the generator script please let me know beforehand.
I want to double-check that implicit conversion not working on a QVariant constructor that fails to compile on my end somehow. But I am not entirely sure I understand what is going on here. I'll take a look over the week-end most likely
I recently pushed a fix for one QVariant constructor introduced with a recent extension. The code compiles fine for on Android. If you see any problems on Android please let me know.
Any update on this one? It's still really useful to have this app on lower versions of Android, especially for graphics developers working with a variety of devices.
This patch changes 2 things that may be unrelated (individual commits):
unsigned long
to QVariant from Qt 5.15)