search

SaschaWillems / glCapsViewer

C++ port of the OpenGL hardware capability viewer
GNU Lesser General Public License v3.0
103 stars 28 forks source link

Fix build on MacOS & some small cmake fixes #33

Closed Hugobros3 closed 1 year ago

Hugobros3 commented 1 year ago

I was surprised to find no MacOS reports on opengl.gpuinfo.org. Fixing the build was not too bad, I had to implement some hacks because of Apple's baffling decision to strictly require core profile to do 3.x calls (and conversely, removing the ability to glGetString(GL_EXTENSIONS) in legacy mode). Since Apple is unlikely to ever implement anything beyond 4.1, this should be fine.

I had to also touch up the CMakeFiles to account for changes in the FindGLEW module, and make sure to not link with glfw when the target is named something else. I might do another pass on the CMakeFiles to modernize them later.

oscarbg commented 1 year ago

nice work, thanks! seen your M1 Max reports! hope can be merged soon and some prebuilt binary can be provided on: http://opengl.gpuinfo.org/download.php

SaschaWillems commented 1 year ago

Thank you very much for your PR. This is very much appreciated

P.S. : I don't have any Mac devices, so I probably won't be able to provide Mac builds on the download page for now.