SaschaWillems / vulkan.gpuinfo.org

Front-End and Back-End for the Vulkan Hardware Database
https://vulkan.gpuinfo.org
GNU Affero General Public License v3.0
23 stars 4 forks source link

Correctly display Imagination Technologies driver versions #27

Closed CaffeinePwrdAl closed 9 months ago

CaffeinePwrdAl commented 3 years ago

Hey Sascha,

Just a quick PR that correctly displays the driverVersion field for Imagination Technologies drivers.

Our driverVersion on production drivers is actually just the Perforce changeset # the release was built from, and not a semantic versioning scheme. In practice each major driver release will compare > than previous releases.

We do have one other scenario I've coded up - and that is if someone is running a development driver (this will actually usually be in-house-runs) - in these cases it has a made up changelist number always > 500,000,000 - I've set those to be formatted as 0.0.512123042 - presuming you use the formatted numbers for column sorting, it should make these appear below the genuine production drivers.

The information in VK_KHR_driver_properties' driverInfo is slightly better and shows our major/minor release branch naming as well as the changeset # - something like "1.11@5742315", where driverVersion would just be 5742315 in this case.

Side question - would you be open to being able to use the driverInfo string to help format a better driver version for output? Or perhaps just along side in italics and/or with a tooltip to indicate it is not actually provided by that field itself if you want to keep the actual fields value distinct? Let me know if you're interested, I don't mind contributing a further pull request.

Regards, Alex

SaschaWillems commented 3 years ago

Sorry for the late reply, I somehow totally missed this PR. Will take a look at it asap and merge and release this to the database.

Side question - would you be open to being able to use the driverInfo string to help format a better driver version for output? Or perhaps just along side in italics and/or with a tooltip to indicate it is not actually provided by that field itself if you want to keep the actual fields value distinct? Let me know if you're interested, I don't mind contributing a further pull request.

Sure. I did something similar some time ago with driver versions for some IHVs. As this adds valuable information, feel free to provide a PR, of let me know the details so I could implement it myself.

SaschaWillems commented 9 months ago

Sorry for the very long delay. Just did some fixes on the back-end and noticed this is still open. Can't merge due to open conflicts, so I manually copied over your change and added it to the database. Hope that's okay for you. Versions for Imagination Technologies should now properly show up.

CaffeinePwrdAl commented 9 months ago

Cheers Sascha, much appreciated 👍

On Sat, 28 Oct 2023 at 06:28, Sascha Willems @.***> wrote:

Closed #27 https://github.com/SaschaWillems/vulkan.gpuinfo.org/pull/27.

— Reply to this email directly, view it on GitHub https://github.com/SaschaWillems/vulkan.gpuinfo.org/pull/27#event-10797571013, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWR5P57NYAM4EZYO23KBLTYBTM3HAVCNFSM4TRKHMX2U5DIOJSWCZC7NNSXTWQAEJEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW4OZRGA3TSNZVG4YTAMJT . You are receiving this because you authored the thread.Message ID: @.*** com>