SaschaWillems / vulkan.gpuinfo.org

Front-End and Back-End for the Vulkan Hardware Database
https://vulkan.gpuinfo.org
GNU Affero General Public License v3.0
23 stars 4 forks source link

Comparison view for extension properties hallucinates unsupported properties #63

Closed per-mathisen-arm closed 1 year ago

per-mathisen-arm commented 1 year ago

Take a look at https://vulkan.gpuinfo.org/compare.php?reports=17913,17914#properties_extensions - Mali does not support the VK_EXT_blend_operation_advanced, for example, but it is listed here with what looks like imaginary values. You can check that the same device report does not list them at all here: http://vulkan.gpuinfo.org/displayreport.php?id=17913#properties_extensions

per-mathisen-arm commented 1 year ago

There is also a discrepancy for https://vulkan.gpuinfo.org/displayreport.php?id=17914#device between the extension list in the web view and the extension list in the linked JSON download. The web view for instance lists many more extensions as supported than the JSON, eg VK_KHR_ray_query is only in the web view.

SaschaWillems commented 1 year ago

The JSON is structured based on the LunarG profiles schema. That'll probably need some update to expose newer features.

Thanks for raising those issues, I'll try to fix both of them.

SaschaWillems commented 1 year ago

Just checked, and this seems to be a mismatch between the device version and how schema files are mapped. I use the patch level from the api version, which in that case is 128 and use that to look up the LunarG JSON schema file to generate the JSON. But this will select a 1.2 schema file that doesn't know about that extension. Will have to think about a way of solving this.

SaschaWillems commented 1 year ago

The wrong value display for the report compare has been fixed. This was a stupid oversight on my side (a variable not getting properly initialized) and affected pretty much all comparisons. It should now work as expected..

I also did some minor changes to the compare pages. The header now also contains the device name (on Android) and some potentially large values are shortened so they don't break the layout.

Again, thanks a lot for bringing this up 👍

per-mathisen-arm commented 1 year ago

Thanks a lot for fixing it! gpuinfo.org is such a useful resource :-)