search

SaschaWillems / vulkan.gpuinfo.org

Front-End and Back-End for the Vulkan Hardware Database
https://vulkan.gpuinfo.org
GNU Affero General Public License v3.0
23 stars 4 forks source link

"0" item is shown in extension comparison #68

Closed krOoze closed 1 year ago

krOoze commented 1 year ago

obrazek

This whole loop looks kinda sus: https://github.com/SaschaWillems/vulkan.gpuinfo.org/blob/e126c43e29075ad1be79521adfad110b23fd22ff/reportcompare/reportcompare.class.php#L464-L476

SaschaWillems commented 1 year ago

Can you post a link to those reports. There are indeed some implementations that report odd stuff that then makes it into the database. Afair I skip NULL extension entries at single report display but not at compare.

krOoze commented 1 year ago

It seems to occur in all reports I have tried: https://vulkan.gpuinfo.org/compare.php?reports=20747,20249#extensions https://vulkan.gpuinfo.org/compare.php?reports=10863,10826#extensions https://vulkan.gpuinfo.org/compare.php?reports=20978,20690#extensions

The code I linked seems to append something to extension names in case of first element in the array. And at first look the nested array looks like one item array of name, so what it adds to the list could be the index 0.