SaskiaFreytag / schex

72 stars 9 forks source link

error when gene name start with number #8

Closed lpantano closed 5 years ago

lpantano commented 5 years ago

Hi,

Thanks for this package, it is pretty awesome!

I have issues when genes are like this 5330434G04Rik, do you think is a general issue or it could be related with my setup?

R> plot_hexbin_gene(sce, type="logcounts", gene="5330434G04Rik",
+                      action="mean", title = "5330434G04Rik")
Error in parse(text = func1) : <text>:1:5: unexpected numeric constant
1: out$5330434

Thanks

R> sessionInfo()
R version 3.6.1 (2019-07-05)
Platform: x86_64-apple-darwin15.6.0 (64-bit)
Running under: macOS Mojave 10.14.3

Matrix products: default
BLAS:   /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib
LAPACK: /Library/Frameworks/R.framework/Versions/3.6/Resources/lib/libRlapack.dylib

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages:
[1] parallel  stats4    stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
 [1] schex_0.1.1                 SingleCellExperiment_1.7.7  SummarizedExperiment_1.15.8
 [4] DelayedArray_0.11.4         BiocParallel_1.19.2         matrixStats_0.54.0         
 [7] Biobase_2.45.0              GenomicRanges_1.37.15       GenomeInfoDb_1.21.1        
[10] IRanges_2.19.14             S4Vectors_0.23.20           BiocGenerics_0.31.5        
[13] forcats_0.4.0               stringr_1.4.0               dplyr_0.8.3                
[16] purrr_0.3.2                 readr_1.3.1                 tidyr_0.8.3                
[19] tibble_2.1.3                tidyverse_1.2.1             ggplot2_3.2.1              
[22] Seurat_3.1.0                knitr_1.24                 
SaskiaFreytag commented 5 years ago

Hi,

I will have a look at this over the weekend.

Cheers,

Saskia

SaskiaFreytag commented 5 years ago

Actually I fixed it. It will now add a G_ before the offending gene starting with a digit.

lpantano commented 5 years ago

super fast, thanks!