Sasmik23 / pe

0 stars 0 forks source link

No error thrown for invalid phone number #4

Open Sasmik23 opened 11 months ago

Sasmik23 commented 11 months ago

Screenshot 2023-11-17 at 4.40.00 PM.png

Able to add patients with less than 8-digit phone numbers. Is this app only to be used in Singapore? Adding invalid phone numbers might make it harder for staff to contact patients.

soc-se-bot commented 11 months ago

Team's Response

We allowed for any phone number as long as it is more than 3 digits as there are many many different formats of phone numbers in the world. Refer to UG as we stipulated that any number more than 3 digits is acceptable. Although we still require NRIC (which limits it to residents of Singapore), the phone number can be an overseas number, due to Singapore's large migrant population.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]