SassDoc / generator-sassdoc-theme

Yeoman generator that scaffolds out a SassDoc theme.
The Unlicense
3 stars 1 forks source link

Include some Sass utilities ? #11

Closed pascalduez closed 9 years ago

pascalduez commented 9 years ago

Should we include some mixins / functions ?

Right now CSS & Sass are empty.

KittyGiraudel commented 9 years ago

First question is: should we include Sass? Chances are high that a SassDoc user uses Sass everywhere but still.

pascalduez commented 9 years ago

The user is prompted on whether to use Sass or not. Default to true. With a friendly little trolling if he don't.

KittyGiraudel commented 9 years ago

Nice one. :P

pascalduez commented 9 years ago

Should we prompt for LESS usage ?

--> :door:

KittyGiraudel commented 9 years ago

Could you add an extra question if the user replies "yes", to ask him if he'd like utilities?

pascalduez commented 9 years ago

Could you add an extra question if the user replies "yes", to ask him if he'd like utilities?

Yep, will do.

KittyGiraudel commented 9 years ago

Cool. ;)

pascalduez commented 9 years ago

Added, it's mostly stuff from the sassdoc-theme-light minus the too specific ones. Maybe @HugoGiraudel you could check if that okay for you ?

KittyGiraudel commented 9 years ago

Why inline comments?

KittyGiraudel commented 9 years ago

Let's get rid of:

pascalduez commented 9 years ago

Why inline comments?

Hé hé, I was waiting this. Would one want to document its theme Sass files, for an already documented Sass project ? Sassception. Well that's already what we do in core :)

KittyGiraudel commented 9 years ago

Then get rid of all comments.

pascalduez commented 9 years ago

I think they are useful. Switch back to CDoc style ?

KittyGiraudel commented 9 years ago

Having inline comments here is really confusing.

pascalduez commented 9 years ago

Agree, I switch back to CDoc

pascalduez commented 9 years ago

opacity mixin requires clamp.

KittyGiraudel commented 9 years ago

Just don't clamp the input value. ;)

pascalduez commented 9 years ago

Done. Feel free to fiddle in there if you want to improve.