SassDoc / sassdoc-theme-default

Default theme for SassDoc.
MIT License
10 stars 30 forks source link

Use `descriptionPath` filter #70

Closed pascalduez closed 9 years ago

pascalduez commented 9 years ago
pascalduez commented 9 years ago

@HugoGiraudel sassdoc-extras 2.3.0 published, please check whether the current description integration suits you.

The thing is, since generated markdown will most likely contains tags (heading, paragraphs,...) they will inherit user agent defaults. Not sure if we should reset or let it as is.

KittyGiraudel commented 9 years ago

The thing is, since generated markdown will most likely contains tags (heading, paragraphs,...) they will inherit user agent defaults. Not sure if we should reset or let it as is.

I think I'll do a little something about this.

KittyGiraudel commented 9 years ago

Please review my commit (also, test it). :)

pascalduez commented 9 years ago

I'm not sure about the fact that if no description is given it should fallback to package.description ? Or at least the "description" title seems redundant and eat space

Those titles are too massive IMO.

screen shot 2015-02-16 at 18 47 01 screen shot 2015-02-16 at 18 48 53 screen shot 2015-02-16 at 18 47 26

KittyGiraudel commented 9 years ago

What do you suggest?

pascalduez commented 9 years ago

I just run a quick test and marked leave inline styles and <style> blocks untouched, which means users could have some control over that description. Comic-sans red for instance

KittyGiraudel commented 9 years ago

Done. All good?

pascalduez commented 9 years ago

Wow, great !

KittyGiraudel commented 9 years ago

@pascalduez Then you can merge. :)

pascalduez commented 9 years ago

Thanks @HugoGiraudel !