search

SassDoc / sassdoc-theme-default

Default theme for SassDoc.
MIT License
10 stars 30 forks source link

Make loading of external resources protocol agnostic to prevent mixed content warnings #90

Closed zeidlos closed 8 years ago

zeidlos commented 8 years ago

We are using your tool, but would love to be able to also serve it via https. This should fix it. :)

zeidlos commented 8 years ago

Fixes https://github.com/SassDoc/sassdoc-theme-default/issues/91

valeriangalliat commented 8 years ago

Thanks!

Realizing that this resource is available over HTTPS, I think it's even better to always load it over HTTPS. Could you update the PR?

pascalduez commented 8 years ago

Protocol-relative URLs are "deprecated" and considered potentially harmful. See http://www.paulirish.com/2010/the-protocol-relative-url/.

So I would rather go with HTTPS as @valeriangalliat suggested.

zeidlos commented 8 years ago

Updated it. I'd be happy if you guys could merge soon, so I gtd. :)

pascalduez commented 8 years ago

:+1:

zeidlos commented 8 years ago

Will you change the version number as well?

pascalduez commented 8 years ago

sassdoc-theme-default@2.4.3 published.