CSS Rules show as "CSSS" in attempt to pluralize

SassDoc / sassdoc-theme-default

Default theme for SassDoc.

MIT License

10 stars 30 forks source link

CSS Rules show as "CSSS" in attempt to pluralize #92

Closed EvanLovely closed 6 years ago

EvanLovely commented 8 years ago

To reproduce; run sassdoc on this:

/// My selector
.class {
  display: block;
}

It shows up as this:

2016-10-20 at 11 27 am

I believe that it tries to pluralize it like it does for mixin => mixins, variable => variables, and is trying css => csss.

Please let me know if this should go in the main sassdoc repo. Great work on this; thanks!

KittyGiraudel commented 8 years ago

This is the right place for this issue. Thank you for reporting. :)

pascalduez commented 8 years ago

https://github.com/SassDoc/sassdoc-theme-default/blob/master/views/includes/partials/sidebar.html.swig#L30 https://github.com/SassDoc/sassdoc-theme-default/blob/master/views/documentation/index.html.swig#L31

KittyGiraudel commented 8 years ago

We could check if last letter is a s I guess.

eblaauw commented 6 years ago

Is there any progress on this issue so far yet?

reneroth commented 6 years ago

bump

LeaveAirykson commented 6 years ago

@pascalduez So the only reaction from you guys is to give a thumbs down to people asking for any progress? wow.

reneroth commented 6 years ago

It's not reddit, thumbs up and down mean nothing :) I'll try to submit a PR this weekend!

KittyGiraudel commented 6 years ago

@LeaveAirykson Hello. The 4 original maintainers of this project no longer have time to work on this project, and we are currently looking for maintainers to go through open issues and pull-requests and try to get the project out of the limbo.

I don’t think @pascalduez meant anything else that “this is not being worked on” with the thumbs down emoji. Don’t take this as a mockery or an offense please.

reneroth commented 6 years ago

@HugoGiraudel what'd your requirements be? I could put some work in, but no promises.

KittyGiraudel commented 6 years ago

@reneroth Thank you, that’s very kind. We recently added two lovely folks to the GitHub organisation to help us. Let’s see how it goes. :)

LeaveAirykson commented 6 years ago

@HugoGiraudel ah, ok that's totally understandable. Thank you very much for clarifying that! (:

pascalduez commented 6 years ago

An issue comment with "any progress?" or "bump" deserve a thumbs down (as meaningless and useless it can be). Or you don't understand open-source.
It will not make the issue self resolve or progress in any way, only increase already high pressure on maintainers.

reneroth commented 6 years ago

Well, a bump comment can have one or more of several uses:

It shows demand for a ticket to be resolved (of course, absolutely useless if done in excess).
It is a gentle reminder for tickets that have been inactive for a long period of time and may have been forgotten by the maintainers (happens to me, too). Otherwise, someone doing routine maintenance might come along and say "hey, no activity for a year in here, let's close this" (I made that mistake too).
It gives opportunity for a discussion about the state of things, as happening here. End result, I'll see about making a PR solving this issue.

But maybe I just don't understand open-source.

LeaveAirykson commented 6 years ago

@pascalduez My point is that a simple comment like the one from @HugoGiraudel would have been enough to inform everyone what's going on instead of just thumbing down comments you think are meaningless without giving any further information. Besides, asking for progress in an open issue is not meaningless at all.

but maybe I just don't understand open-source.

reneroth commented 6 years ago

see PR #101

no offense was meant by my bumping.

pascalduez commented 6 years ago

sassdoc-theme-default@2.6.2 thanks @reneroth!