Linted the whole codebase to standard

[KittyGiraudel]

I think there is a test not passing and I’m not sure why.

[KittyGiraudel]

Damn. I recall we agreed we would move to standard. 😁

The reason why I would like to use it is that it would make sure:

• All our repositories use the exact same linting configuration, no matter what.
• Contributors familiar with (semi)standard do not have to change their habits to push code.
• There is no discussion around linting as this is rather pointless.

Do you feel like you can cope with the lack of semicolon or shall we use semistandard? I know @valeriangalliat was very much pro standard. So am I. Not sure for @FWeinb.

[pascalduez]

That was the issue: #447. Where we agreed on Standard, but not clearly on semi or not.

I'm a bit worried about such massive changes, and as we can see the automation broke a few things along the way. Given we all have barely much time to allow to the project, if we can limit the possible sources of issues, might be good.

I kind of like the way I setup here: https://github.com/SassDoc/broccoli-sassdoc/blob/master/.eslintrc so you have all the benefits of Standard, but with the confort of ESLint.

Anyway, I will follow the consensus, no big deal.

[KittyGiraudel]

I'm a bit worried about such massive changes, and as we can see the automation broke a few things along the way. Given we all have barely much time to allow to the project, if we can limit the possible sources of issues, might be good.

It wasn’t automation. I removed all semi-colons from the project with a search and replace. :D

[KittyGiraudel]

I’m not too worried as we have good test coverage. Also there will be no direct release following this change.

[pascalduez]

I would like to make a release with the dependencies upgrades, so better not merge this one right now ;)

[coveralls]

Coverage increased (+0.005%) to 94.618% when pulling 9152b36bef843fd430b652d6643b15b21fb237be on feature/standard into 8aad8c1e9f5d883c51f19786483e949bb816fe8f on master.

[pascalduez]

Once again, unit tests ❤️

[KittyGiraudel]

I would like to make a release with the dependencies upgrades, so better not merge this one right now ;)

Makes sense. :)

[coveralls]

Coverage increased (+0.005%) to 94.618% when pulling 1fecc421592ba4605743c5c902a91c3ce2512202 on feature/standard into 8aad8c1e9f5d883c51f19786483e949bb816fe8f on master.

[pascalduez]

One pain point about using standard that way, we need yet another editors plugin to have code linting in place, since ESLint is all hidden underneath.

[KittyGiraudel]

I’m not sure what you mean.

[pascalduez]

I use plugins in Atom or Vim to get "in place linting" (in the code directly), not just by running the npm command. Those ESLint plugins works independently of the config/preset you have. Standard included.

But since standard is a package on top of ESLint somehow abstracting it, and we have no .eslintrc or eslint key in package.json anymore those plugins don't work. And we need yet another plugin to make it work.

Using Standard the ESLint way is just (if I'm not mistaken):

// .eslintrc
---
extends: "standard"

[KittyGiraudel]

We could add back the .eslintrc file?

[pascalduez]

Anyway, plugins installed, all good. Leave it as is.

[pascalduez]

sassdoc@2.2.0 and sassdoc-theme-default@2.5.2 released. Should get rid of most of the security or deprecation warnings.

Good to go for this MR.

[pascalduez]

So I rebased and fixed the whole damn thing :) Let's see what the CI says.

[coveralls]

Coverage decreased (-0.02%) to 94.345% when pulling e124d1894f9a9fd92c0fc1ee61d4cc1950dad82e on feature/standard into 2ea9ede361ebcdea2c68538bcb5afc2f2085d267 on master.

[coveralls]

Coverage decreased (-0.02%) to 94.345% when pulling a7779565adc8d63013d4ec338b94bc72691ba934 on feature/standard into 2ea9ede361ebcdea2c68538bcb5afc2f2085d267 on master.