Scope empty data warning under the verbose flag

SassDoc / sassdoc

Release the docs!

http://sassdoc.com

MIT License

1.41k stars 56 forks source link

Scope empty data warning under the verbose flag #489

Closed pascalduez closed 7 years ago

pascalduez commented 7 years ago

See #488

I tried to only scope that warning, so that we don't drastically change all the other behaviours (annotation warnings etc.).

Also removed the CSS selector sentence from the warning since this is no longer true, although we don't do much promotion around it.

coveralls commented 7 years ago

Coverage increased (+0.01%) to 94.356% when pulling c575fc5dea32aed590825531dc21d252573f92de on features/verbose-extend into e00be6b880e994f1e98662e6153743164f45abb6 on master.

KittyGiraudel commented 7 years ago

Looks very good to me. :)

pascalduez commented 7 years ago

How do we ship that change, patch, minor?

KittyGiraudel commented 7 years ago

I'd say patch? Not sure.

On Wed, 22 Mar 2017, 13:45 Pascal Duez, notifications@github.com wrote:

How do we ship that change, patch, minor?

— You are receiving this because your review was requested.

Reply to this email directly, view it on GitHub https://github.com/SassDoc/sassdoc/pull/489#issuecomment-288387394, or mute the thread https://github.com/notifications/unsubscribe-auth/ABzVrrdYyNAbOa0prg2wXvHFHdSNROALks5roRf6gaJpZM4Mj-HO .

pascalduez commented 7 years ago

+ sassdoc@2.2.1