Prevent duplicate entries in requirements

SassDoc / sassdoc

Release the docs!

http://sassdoc.com

MIT License

1.41k stars 56 forks source link

Prevent duplicate entries in requirements #532

Closed reneroth closed 1 year ago

reneroth commented 5 years ago

Fixes issue #530 :)

coveralls commented 5 years ago

Coverage increased (+0.01%) to 94.69% when pulling 7bb4ce867bedcf72afad7c8fca4a0c9a9c118e45 on reneroth:fix/dependency-duplication into c80a23f05ae9da4990d417f18d3b2f45dbaf0ec3 on SassDoc:master.

castastrophe commented 3 years ago

This would be very helpful for my team - is there any way I can help to get this PR merged and a release rolled with it?

pascalduez commented 3 years ago

@castastrophe Hello, yes, we would like a few unit tests added to assert the behavior/change works as intended and prevent later regressions.

Don't hesitate to ask if you need guidance.

castastrophe commented 3 years ago

[ ] @castastrophe to add unit tests

[adding this as a reminder to myself to pick this up]

reneroth commented 2 years ago

👀

castastrophe commented 2 years ago

@reneroth Sorry about this - I committed to doing this and promptly started a new job and have been doing some intense onboarding. I'll see if I can get back into this at some point in the near future but also open to anyone else picking it up if they like.

reneroth commented 2 years ago

@reneroth Sorry about this - I committed to doing this and promptly started a new job and have been doing some intense onboarding. I'll see if I can get back into this at some point in the near future but also open to anyone else picking it up if they like.

Haha no worries friend! I just stumbled across this when reviewing my open pull requests, completely forgot about it :D

reneroth commented 1 year ago

Closing this PR for selfish reasons because I want an "inbox zero" kind of feeling for my PR list.
Code is functional if anyone still needs it.