SassDoc / sassdoc

Release the docs!
http://sassdoc.com
MIT License
1.41k stars 56 forks source link

Fix broken anchor links (#464, #465) #567

Closed valeriangalliat closed 2 years ago

valeriangalliat commented 2 years ago

Rebased version of #465 with addressed PR comments.

Fixes #464, closes #465.

valeriangalliat commented 2 years ago

@d13 thanks for reviewing!

So my understanding is that this solution is not perfect but still yields better results than if we don't land it. Also it needs extra theme code to be useful.

What I can do is:

Does that sounds good?


As for the alias issue when multiple contexts share the same name, I'm not sure from the top of my head how that can be fixed (haven't worked with SassDoc in the past... many years) but I'll definitely accept a PR for it!

kdaulton-chwy commented 2 years ago

@valeriangalliat thanks!

Yes, I agree this is an improvement!

I'll definitely put up the PR for sassdoc-theme-default.

I'll also put some time into how to solve the alias with same name issue.

(sorry for the confusion in users, just realized i'm commenting from my work account)

valeriangalliat commented 2 years ago

Great! Thanks for the PR on sassdoc-theme-default

This is released with sassdoc@2.7.4